meteor-deploy icon indicating copy to clipboard operation
meteor-deploy copied to clipboard

fix bug with io after exit signal

Open DaanVanVugt opened this issue 9 years ago • 2 comments

This fixes a bug with meteor-deploy on my machine, related to https://nodejs.org/api/child_process.html#child_process_event_exit

DaanVanVugt avatar Mar 11 '15 11:03 DaanVanVugt

Hey there, thanks for the pull request!

Changing the exit signal is fine by me. In the other change you are relying on meteor server to preprocess your scss for 10 seconds I'm guessing?

xenolf avatar Mar 11 '15 20:03 xenolf

Hi Xenolf,

That is to work around a bug with ionicons-sass (in meteoric/meteor-ionic). The build process always crashes the first time because those files are not there, because they are placed there later in the build process. This works around that, but should not be necessary once they change the dependency handling in the build process. I linked to the bug reports in the source.

Best, Daan

ps. Due to some other issues on debian I decided to move to a capistrano script, which seems to work nicely as well

On Wed, Mar 11, 2015 at 9:14 PM, xenolf [email protected] wrote:

Hey there, thanks for the pull request!

Changing the exit signal is fine by me. In the other change you are relying on meteor server to preprocess your scss for 10 seconds I'm guessing?

— Reply to this email directly or view it on GitHub https://github.com/xenolf/meteor-deploy/pull/4#issuecomment-78361085.

DaanVanVugt avatar Mar 11 '15 20:03 DaanVanVugt