Certain STFS containers crash xenia

[Nukem9]

These are CON/signed. I found this bug while testing skyrim saves:

Crashes on https://github.com/benvanik/xenia/blob/master/src/xenia/vfs/devices/stfs_container_device.cc#L150 (filename 0x00000095b2b94000 <Error reading characters of string.>) Occasionally crashes on https://github.com/benvanik/xenia/blob/master/src/xenia/vfs/devices/stfs_container_device.cc#L168 (all_entries contains zero elements)

The vanilla skyrim save works fine, while the same file modified with Horizon's editor crashes. To reproduce, go to File -> Open -> Select a container (attached). Neither containers have XEXs or anything - it's just to reproduce the crash.

exs.zip

[x1nixmzeng]

Thanks for providing the files to reproduce this :+1:

The occasional crash is interesting - I think it may be related to the other issue of not resetting properly?

[Sleepy93]

If I select a game which wrote with God2Iso (1.3.6) Xenia crashing and in the logs I can see STFS Container version 2 is not supported yet.

w> 000024B8 STFSContainer doesn't support version 2 yet

Will Xenia support STFS Container version 2?