xenia icon indicating copy to clipboard operation
xenia copied to clipboard

[STFS] Add critical section to file reading

Open Gliniak opened this issue 2 years ago • 0 comments

Affected titles: https://github.com/xenia-project/game-compatibility/issues/827 https://github.com/xenia-project/game-compatibility/issues/125

Description: These titles use multiple threads to load same file, which in case of extracted file doesn't make any issue, however for STFS package it is huge problem as it can randomly receive incorrect data.

I checked it multiple times and calculated hashes of loaded data between extracted and packed game. Conclusion for me is simple, at certain point thread starts getting invalid data, which is simply resolved by including critical section

Gliniak avatar Feb 05 '23 11:02 Gliniak