xenia icon indicating copy to clipboard operation
xenia copied to clipboard

moved clang-format to tools directory

Open p01arst0rm opened this issue 2 years ago • 4 comments

Moved the clang-format tool into the /tools directory.

p01arst0rm avatar Dec 29 '22 14:12 p01arst0rm

It's a third-party component, why (and also why #2098)? For the ease of managing licenses and updating, we don't put, for instance, the Vulkan headers in src/xenia/ui/vulkan.

Triang3l avatar Dec 29 '22 16:12 Triang3l

I accepted #2098 because vswhere is a binary, I don't think we need to move clang-format.

gibbed avatar Dec 29 '22 16:12 gibbed

Thank you

Devman219 avatar Dec 29 '22 16:12 Devman219

It's a third-party component, why (and also why #2098)? For the ease of managing licenses and updating, we don't put, for instance, the Vulkan headers in src/xenia/ui/vulkan.

using a single directory to contain all third party code is a legacy buildsystem design technique. placing tools in directories that align with their actual project use is easier;- it also allows you to ignore entire directories to exclude them from packages. newer project layouts place documentation in /doc tools in /tools data in /data and so on

There is also some code within third_party which is actually xenia project code, the third_party label appears to be entirely arbitrary .

p01arst0rm avatar Dec 29 '22 17:12 p01arst0rm