xenia icon indicating copy to clipboard operation
xenia copied to clipboard

Run Clang Format on Pull Requests

Open halotroop2288 opened this issue 3 years ago • 2 comments

xb format just doesn't work whatsoever for me. It's really making my pull requests difficult. It would be very nice if you could automatically format PRs that have "allow edits by maintainers" checked.

Here is an example, just to show you it's possible: https://github.com/chipsalliance/verible/pull/914

Originally posted by @halotroop2288 in https://github.com/xenia-project/xenia/issues/1978#issuecomment-1028807288

halotroop2288 avatar Feb 05 '22 02:02 halotroop2288

Personally I dont like the idea of ci changing the commits at all. I would rather try to find out whats wrong with xb format on your system. Personally, I use IDE plugins that auto format to the projects .clang-format file on save and that has been very helpful

JoelLinn avatar Feb 05 '22 10:02 JoelLinn

Feel free to meet me in voice chat on the Discord if you really want to solve this issue on my end. But it will happen again, to me (when I reinstall Windows) or someone else who is contributing to Xenia for the first time.

Linting is a really crappy reason to hold all progress up, this is a one-size-fits-all solution to it. You could make it automatic, or manual by adding a comment command if you're afraid that a missing semicolon might cause a major issue.

halotroop2288 avatar Feb 06 '22 20:02 halotroop2288