xenia icon indicating copy to clipboard operation
xenia copied to clipboard

XAM functions relying on XMsgStartIORequestEx need to reset the provided event in XAM_OVERLAPPED

Open gibbed opened this issue 2 years ago • 0 comments

XMsgStartIORequestEx will reset the event specified in XAM_OVERLAPPED if completion_routine is null.

Currently our XAM implementation for a lot of functions that use XMsgStartIORequestEx/XMsgStartIORequest internally don't actually use this. This needs to be addressed somehow.

Any title that passes in a signaled event, such as title 58410A6F, to any of these functions will likely fail and have issues.

XAM function exports that take a XAM_OVERLAPPED argument that Xenia currently implements that need to be checked if they use XMsgStartIORequestEx and corrected if necessary.

The ideal situation is that we properly implement XMsgStartIORequestEx and make use of it in our implementation of the export functions.

  • [ ] XamAvatarGetMetadataLocalUser
  • [ ] XamAvatarGetMetadataRandom
  • [ ] XamAvatarGetAssets
  • [ ] XamAvatarLoadAnimation
  • [ ] XamAvatarGenerateMipMaps
  • [ ] XamContentGetLicenseMask
  • [ ] XamContentCreate
  • [ ] XamContentCreateEx
  • [ ] XamContentCreateInternal
  • [ ] XamContentOpenFile
  • [ ] XamContentFlush
  • [ ] XamContentClose
  • [ ] XamContentGetCreator
  • [ ] XamContentGetThumbnail
  • [ ] XamContentSetThumbnail
  • [ ] XamContentDelete
  • [ ] XamContentDeleteInternal
  • [ ] XamContentGetDeviceState
  • [ ] XamEnumerate
  • [ ] XMsgStartIORequestEx
  • [ ] XMsgStartIORequest
  • [ ] XMsgCancelIORequest
  • [ ] XamGetOverlappedResult
  • [ ] XamProfileEnumerate
  • [ ] XamShowMessageBoxUI
  • [ ] XamShowKeyboardUI
  • [ ] XamShowDeviceSelectorUI
  • [ ] XamUserReadProfileSettings
  • [ ] XamUserReadProfileSettingsEx
  • [ ] XamUserWriteProfileSettings
  • [ ] XamUserContentRestrictionCheckAccess
  • [ ] XamUserAreUsersFriends
  • [ ] XamReadTile
  • [ ] XamReadTileToTexture
  • [ ] XamWriteGamerTile
  • [ ] XamUserFlushLogonQueue

gibbed avatar Jan 08 '22 19:01 gibbed