xemu icon indicating copy to clipboard operation
xemu copied to clipboard

ui: Handle snapshots with empty names in snapshot menu

Open antangelo opened this issue 1 year ago • 2 comments

Snapshots without names are somewhat difficult to create (must use savevm "" in the monitor, QMP, or qemu-img) but should be handled correctly regardless.

This requires adding an additional present bool to the config. I preserved compatibility with existing shortcut bindings by checking the present field or that the shortcut snapshot name string is not empty.

Fixes #1543

antangelo avatar Oct 26 '23 20:10 antangelo

Should we just prevent creating snapshots with the empty string as the name? This seems like a lot of work to handle this weird case

mborgerson avatar Jun 17 '24 22:06 mborgerson

We can prevent them from being created within xemu, but that won't cover existing empty-name snapshots or those created by qemu-img (which are also niche cases).

antangelo avatar Jun 18 '24 00:06 antangelo