xemu icon indicating copy to clipboard operation
xemu copied to clipboard

Incorrect xemu SVG icon

Open j8r opened this issue 2 years ago • 9 comments

Bug Description

When seeing https://github.com/mborgerson/xemu/blob/master/ui/icons/xemu.svg, we can notice that the xemu name is on the right side, going through the circle, instead of being centered.

Expected Behavior

The xemu icon should look like https://github.com/mborgerson/xemu/blob/master/ui/icons/xemu_512x512.png.

xemu Version

All

System Information

No response

Additional Context

No response

j8r avatar Jul 11 '22 18:07 j8r

Most likely an issue with your SVG renderer.

dracc avatar Jul 11 '22 18:07 dracc

No, because it looks like this on GitHub, locally in my desktop and Android phone. Have you tried to open the link?

j8r avatar Jul 11 '22 20:07 j8r

The offset is different though. It could be a fixed left padding, which may looks well on some screens but not on others. I'm not familiar with how SVG works internally so that's just a guess.

j8r avatar Jul 11 '22 20:07 j8r

Try opening the icon in Inkscape. Looks fine for me on GH/firefox

mborgerson avatar Jul 11 '22 22:07 mborgerson

Same issue screen

My screen resolution is 1920x1080, may be related.

Also in my phone there is still an offset. but one a bit less pronounced. Screenshot_20220712-005622_Firefox

j8r avatar Jul 11 '22 22:07 j8r

You may need to install the xemu font (ubuntu mono), probably the text should just be converted to a path

mborgerson avatar Jul 11 '22 23:07 mborgerson

Right the font is not the same! An SVG shall be self-contained to properly fix the issue for all cases. Maybe there is an option in Inkscape to import/embed font characters.

j8r avatar Jul 11 '22 23:07 j8r

Also broken on my phone.

GXTX avatar Jul 12 '22 22:07 GXTX

The SVG text is referencing a font not installed on users' systems. The font needs to be converted into a shape/path in Illustrator so it renders correctly on any system without the font.

GitYukari avatar Jul 25 '22 21:07 GitYukari