htmlpurifier-html5 icon indicating copy to clipboard operation
htmlpurifier-html5 copied to clipboard

PHP 8.4

Open sidewaysglance opened this issue 1 year ago • 2 comments
trafficstars

Hi,

Just wondering if there's anything interesting coming in PHP 8.4 as far as this wonderful library is concerned?

Cheers

sidewaysglance avatar Jul 28 '24 21:07 sidewaysglance

At least, there is a deprecated in PHP 8.4.0alpha4 here https://github.com/xemlock/htmlpurifier-html5/blob/0105fef4434915ae66c31d00af2bd362623f116d/library/HTMLPurifier/HTML5Config.php#L65

Deprecated: HTMLPurifier_HTML5Config::__construct(): Implicitly marking parameter $parent as nullable is deprecated, the explicit nullable type must be used instead in [...]library/HTMLPurifier/HTML5Config.php on line 65
-    public function __construct(HTMLPurifier_ConfigSchema $schema, HTMLPurifier_PropertyList $parent = null)
+    public function __construct(HTMLPurifier_ConfigSchema $schema, ?HTMLPurifier_PropertyList $parent = null)

marcimat avatar Aug 27 '24 14:08 marcimat

Hi! Thanks for pointing that out. I'm planning on making the code PHP 8.4 compatible, as well as use new DOM parsing abilities provided by DOM\HTMLDocument.

xemlock avatar Aug 31 '24 11:08 xemlock

It would be great to have a release with PHP 8.4 support initially, so we don't depend on master in stable projects.

phppress avatar Mar 04 '25 10:03 phppress

@xemlock Are there any plans to create a tag for those changes with PHP8.4 support?

DmytroPolavis avatar Mar 25 '25 14:03 DmytroPolavis

@xemlock would it be possible to make a tag? ... thanks :))

tg666 avatar Jun 16 '25 02:06 tg666

@xemlock Thanks for the tool, there is a possibility of a tag with the PHP 8.4 fixes, thks.

terabytesoftw avatar Sep 13 '25 22:09 terabytesoftw