htmlpurifier-html5 icon indicating copy to clipboard operation
htmlpurifier-html5 copied to clipboard

Update CommonAttributes.php

Open bytestream opened this issue 3 years ago • 1 comments
trafficstars

This copies CommonAttributes changes in v4.15.0 from upstream, otherwise contenteditable="false" is not considered valid on HTML5 doc types.

It also bumps the requirements to match ezyang/htmlpurifier in v4.15.0

bytestream avatar Sep 09 '22 20:09 bytestream

@xemlock this OK?

bytestream avatar Sep 21 '22 16:09 bytestream

Hi @bytestream, yes it should suffice. Thanks!

xemlock avatar Nov 16 '22 08:11 xemlock

I've just noticed that versions matrix has been modified. So after a bit of thought, I'm in strong favor of adding our own, in-library definition for this attribute, to avoid impacting dependency versions.

xemlock avatar Nov 16 '22 08:11 xemlock

Superseded by #79.

xemlock avatar Nov 16 '22 09:11 xemlock