yocto-gl
yocto-gl copied to clipboard
Accepts content type jsonlines
What changes are proposed in this pull request?
I wrote a function to parse line-delimited JSON (more details here).
As detailed in this issue, application/jsonlines
is the recommended CONTENT_TYPE
when deploying a model to SageMaker Batch Transform.
How is this patch tested?
I added the relevant tests in tests/pyfunc/test_scoring_server
, namely
-
test_scoring_server_responds_to_invalid_jsonlines_input_with_stacktrace_and_error_code
-
test_scoring_server_successfully_evaluates_correct_dataframes_with_jsonlines
-
test_jsonlines_to_df
Does this PR change the documentation?
- [x] No. You can skip the rest of this section.
- [ ] Yes. Make sure the changed pages / sections render correctly by following the steps below.
- Check the status of the
ci/circleci: build_doc
check. If it's successful, proceed to the next step, otherwise fix it. - Click
Details
on the right to open the job page of CircleCI. - Click the
Artifacts
tab. - Click
docs/build/html/index.html
. - Find the changed pages / sections and make sure they render correctly.
Release Notes
Is this a user-facing change?
- [x] No. You can skip the rest of this section.
- [ ] Yes. Give a description of this change to be included in the release notes for MLflow users.
(Details in 1-2 sentences. You can just refer to another PR with a description if this PR is part of a larger change.)
What component(s), interfaces, languages, and integrations does this PR affect?
Components
- [ ]
area/artifacts
: Artifact stores and artifact logging - [ ]
area/build
: Build and test infrastructure for MLflow - [ ]
area/docs
: MLflow documentation pages - [ ]
area/examples
: Example code - [ ]
area/model-registry
: Model Registry service, APIs, and the fluent client calls for Model Registry - [x]
area/models
: MLmodel format, model serialization/deserialization, flavors - [ ]
area/projects
: MLproject format, project running backends - [x]
area/scoring
: MLflow Model server, model deployment tools, Spark UDFs - [ ]
area/server-infra
: MLflow Tracking server backend - [ ]
area/tracking
: Tracking Service, tracking client APIs, autologging
Interface
- [ ]
area/uiux
: Front-end, user experience, plotting, JavaScript, JavaScript dev server - [ ]
area/docker
: Docker use across MLflow's components, such as MLflow Projects and MLflow Models - [ ]
area/sqlalchemy
: Use of SQLAlchemy in the Tracking Service or Model Registry - [ ]
area/windows
: Windows support
Language
- [ ]
language/r
: R APIs and clients - [ ]
language/java
: Java APIs and clients - [ ]
language/new
: Proposals for new client languages
Integrations
- [ ]
integrations/azure
: Azure and Azure ML integrations - [ ]
integrations/sagemaker
: SageMaker integrations - [ ]
integrations/databricks
: Databricks integrations
How should the PR be classified in the release notes? Choose one:
- [ ]
rn/breaking-change
- The PR will be mentioned in the "Breaking Changes" section - [ ]
rn/none
- No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section - [x]
rn/feature
- A new user-facing feature worth mentioning in the release notes - [ ]
rn/bug-fix
- A user-facing bug fix worth mentioning in the release notes - [ ]
rn/documentation
- A user-facing documentation change worth mentioning in the release notes
Hi @alexdivet , are there any updates here?
Hi @alexdivet , are there any updates here?
Hi @alexdivet , are there any updates here?
hi @dbczumar – I'm afraid my priorities have shifted lately and I haven't found time to dedicate to this. I guess you can close this PR for now and I'll open a new one with your suggested changes later when I get back to it
No problem, @alexdivet. I'm going to go ahead and close this for now :)