yocto-gl icon indicating copy to clipboard operation
yocto-gl copied to clipboard

[BUG] Alias for model version doesn't show up in the table

Open elvira-salakhova-r opened this issue 1 year ago • 4 comments

Willingness to contribute

No. I cannot contribute a bug fix at this time.

MLflow version

2.9.2

System information

  • OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Debian GNU/Linux 10 (buster)
  • Python version: 3.9.18

Describe the problem

Inside the Models section when a certain model is selected there is a pivot table with model versions, their tags and aliases. After assigning an alias via button "Add" from UI or from code using client.set_registered_model_alias method, the alias doesn't show up in the pivot table.

When I click the button "Add" for the model version I've just assigned the alias, the alias becomes visible in search panel as if it was actually assigned. The method client.get_model_version_by_alias also return the correct alias.

So, the problem is that column "Aliases" won't display any aliases even if they are set.

The expected behavior is the following: after setting an alias it should be displayed in the pivot table similarly to the "Tags" column.

Steps to reproduce the bug

https://github.com/mlflow/mlflow/assets/147606144/c48be945-1dd3-4dd7-b046-99e0211d431a

Code to generate data required to reproduce the bug

No response

Is the console panel in DevTools showing errors relevant to the bug?

No response

Does the network panel in DevTools contain failed requests relevant to the bug?

No response

elvira-salakhova-r avatar Jan 31 '24 10:01 elvira-salakhova-r

Thanks, this is definitely a UI bug. We'll look into fixing it. cc @hubertzub-db

BenWilson2 avatar Feb 05 '24 19:02 BenWilson2

@elvira-salakhova-r I couldn't reproduce the bug on v2.9.2 nor on the latest version (videos attached). Can you confirm the bug still persists on the latest version from master branch, i.e. v2.10.1? If true: is it possible for you to record the screen while having browser developer tools -> "Network" tab open?

https://github.com/mlflow/mlflow/assets/104438646/f3dcd305-3396-45b2-b9d1-bff3c2c5e389

https://github.com/mlflow/mlflow/assets/104438646/d8f94ee8-03b4-4452-8907-c1fca14bd470

hubertzub-db avatar Feb 06 '24 11:02 hubertzub-db

@mlflow/mlflow-team Please assign a maintainer and start triaging this issue.

github-actions[bot] avatar Feb 08 '24 00:02 github-actions[bot]

@hubertzub-db Maybe its due the used storage backend? I saw an issue here about File-Based storages having no problems with serving aliases, but database may dont fill them due performance reasons: https://github.com/mlflow/mlflow/issues/9783

wattux avatar Feb 14 '24 10:02 wattux

I can confirm that I also run into the same issue when using a PostgreSQL storage backend. With it the alias tag is not shown like @elvira-salakhova-r mentioned here.

ippen avatar Feb 21 '24 14:02 ippen

@ippen thanks a lot! @jerrylian-db @smurching can you take a look at this one? It seems that aliases API is breaking when database backend is being used

hubertzub-db avatar Feb 21 '24 19:02 hubertzub-db

Thanks for flagging, I'll take a look at this & options for a fix

smurching avatar Feb 22 '24 01:02 smurching