yocto-gl icon indicating copy to clipboard operation
yocto-gl copied to clipboard

[BUG] Unable to Execute Tests with Only Test Requirements Installed from test-requirements.txt.

Open manijhariya opened this issue 1 year ago • 6 comments

Summary

The issue pertains to the inability to run tests when exclusively installing the required dependencies specified in the test-requirements.txt file. The provided fix addresses this issue, enabling the successful execution of tests under these circumstances.

Notes

  • Make sure to open a PR from a non-master branch.

  • Sign off the commit using the -s flag when making a commit:

    git commit -s -m "..."
             # ^^ make sure to use this
    
  • Include #{issue_number} (e.g. #123) in the PR description when opening a PR.

manijhariya avatar Jan 12 '24 05:01 manijhariya

@manijhariya can you install pyspark manually? We don't always need pyspark. pyspark is a large package and takes a while to install.

harupy avatar Jan 15 '24 02:01 harupy

yeah I did installed pyspark manually. It was not listed in test-requirements.txt. I thought it was missing from there. It should at least be in extra requirements to let devs. know it is required package.

manijhariya avatar Jan 15 '24 05:01 manijhariya

@mlflow/mlflow-team Please assign a maintainer and start triaging this issue.

github-actions[bot] avatar Jan 20 '24 00:01 github-actions[bot]

Can I work on this ? How do I start working on this like fork the repository, create a branch, make changes, and submit a pull request??

kru2710shna avatar Feb 05 '24 09:02 kru2710shna

Does my fix solve this issue? https://github.com/mlflow/mlflow/pull/10996

filippopellizzari avatar Feb 12 '24 11:02 filippopellizzari

Yes. can you type pip install -r requirement.txt" and added optuna as well. #11090PR

kru2710shna avatar Feb 13 '24 20:02 kru2710shna