yocto-gl icon indicating copy to clipboard operation
yocto-gl copied to clipboard

Refactor: move tests cases to pytest in SQLAlchemy test suite [ver#7]

Open TomeHirata opened this issue 1 year ago • 6 comments

Related Issues/PRs

https://github.com/mlflow/mlflow/issues/10042

What changes are proposed in this pull request?

This is the 6th PR of https://github.com/mlflow/mlflow/issues/10042, which tries to refactor https://github.com/mlflow/mlflow/blob/master/tests/store/tracking/test_sqlalchemy_store.py into the pytest style

How is this PR tested?

  • [x] Existing unit/integration tests
  • [ ] New unit/integration tests
  • [ ] Manual tests

Does this PR require documentation update?

  • [x] No. You can skip the rest of this section.
  • [ ] Yes. I've updated:
    • [ ] Examples
    • [ ] API references
    • [ ] Instructions

Release Notes

Is this a user-facing change?

  • [x] No. You can skip the rest of this section.
  • [ ] Yes. Give a description of this change to be included in the release notes for MLflow users.

What component(s), interfaces, languages, and integrations does this PR affect?

Components

  • [ ] area/artifacts: Artifact stores and artifact logging
  • [ ] area/build: Build and test infrastructure for MLflow
  • [ ] area/deployments: MLflow Deployments client APIs, server, and third-party Deployments integrations
  • [ ] area/docs: MLflow documentation pages
  • [ ] area/examples: Example code
  • [ ] area/model-registry: Model Registry service, APIs, and the fluent client calls for Model Registry
  • [ ] area/models: MLmodel format, model serialization/deserialization, flavors
  • [ ] area/recipes: Recipes, Recipe APIs, Recipe configs, Recipe Templates
  • [ ] area/projects: MLproject format, project running backends
  • [ ] area/scoring: MLflow Model server, model deployment tools, Spark UDFs
  • [ ] area/server-infra: MLflow Tracking server backend
  • [ ] area/tracking: Tracking Service, tracking client APIs, autologging

Interface

  • [ ] area/uiux: Front-end, user experience, plotting, JavaScript, JavaScript dev server
  • [ ] area/docker: Docker use across MLflow's components, such as MLflow Projects and MLflow Models
  • [ ] area/sqlalchemy: Use of SQLAlchemy in the Tracking Service or Model Registry
  • [ ] area/windows: Windows support

Language

  • [ ] language/r: R APIs and clients
  • [ ] language/java: Java APIs and clients
  • [ ] language/new: Proposals for new client languages

Integrations

  • [ ] integrations/azure: Azure and Azure ML integrations
  • [ ] integrations/sagemaker: SageMaker integrations
  • [ ] integrations/databricks: Databricks integrations

How should the PR be classified in the release notes? Choose one:

  • [x] rn/none - No description will be included. The PR will be mentioned only by the PR number in the "Small Bugfixes and Documentation Updates" section
  • [ ] rn/breaking-change - The PR will be mentioned in the "Breaking Changes" section
  • [ ] rn/feature - A new user-facing feature worth mentioning in the release notes
  • [ ] rn/bug-fix - A user-facing bug fix worth mentioning in the release notes
  • [ ] rn/documentation - A user-facing documentation change worth mentioning in the release notes

TomeHirata avatar Dec 17 '23 14:12 TomeHirata

Documentation preview for 767431ae32ecf0d2130008a330f20a215349f9d8 will be available when this CircleCI job completes successfully.

More info
  • Ignore this comment if this PR does not change the documentation.
  • It takes a few minutes for the preview to be available.
  • The preview is updated when a new commit is pushed to this PR.
  • This comment was created by https://github.com/mlflow/mlflow/actions/runs/7938292124.

github-actions[bot] avatar Dec 17 '23 14:12 github-actions[bot]

@TomeHirata Thanks for the PR! Btw, any updates for the rate limits feature?

harupy avatar Dec 18 '23 00:12 harupy

any updates for the rate limits feature?

Sorry, I couldn't work on that ticket since my main work has been busy for the past couple of weeks. I read the design doc, and asked one question on the PR.

TomeHirata avatar Dec 18 '23 22:12 TomeHirata

@harupy Could you please take a look when you have time? Some checks are failing probably since I initially created this PR as draft.

TomeHirata avatar Dec 20 '23 15:12 TomeHirata

@harupy Sorry, could you take a look at this PR?

TomeHirata avatar Jan 19 '24 01:01 TomeHirata

@BenWilson2 Would it be possible for you to review this MR?

TomeHirata avatar Jan 22 '24 13:01 TomeHirata

@TomeHirata Sorry for the delay. Could you rebase on master?

harupy avatar Feb 17 '24 00:02 harupy

Rebased, could you help release it?

TomeHirata avatar Feb 17 '24 01:02 TomeHirata