yocto-gl icon indicating copy to clipboard operation
yocto-gl copied to clipboard

[ MLflow Roadmap ] Official MLflow docker image support - slim & full version

Open serena-ruan opened this issue 1 year ago • 22 comments

Summary

Original discussion: https://github.com/mlflow/mlflow/issues/9513

Based on this issue, we would like to introduce two docker images, one MLflow-slim version with no extra dependencies, and one MLflow version with DB related dependencies such as postgres or MySQL.

We should also update CI for pushing both images.

Notes

  • Make sure to open a PR from a non-master branch.

  • Sign off the commit using the -s flag when making a commit:

    git commit -s -m "..."
             # ^^ make sure to use this
    
  • Include #{issue_number} (e.g. #123) in the PR description when opening a PR.

serena-ruan avatar Nov 16 '23 03:11 serena-ruan

Can I work on this?

rajveer43 avatar Nov 16 '23 10:11 rajveer43

@rajveer43 Sounds good! Thanks for volunteering :) Assigned to you!

serena-ruan avatar Nov 16 '23 10:11 serena-ruan

thanks

rajveer43 avatar Nov 20 '23 07:11 rajveer43

@mlflow/mlflow-team Please assign a maintainer and start triaging this issue.

github-actions[bot] avatar Nov 24 '23 00:11 github-actions[bot]

some points to start! a bit idea would help!, @serena-ruan

rajveer43 avatar Nov 26 '23 04:11 rajveer43

If you feel the task is a bit to complex for you @rajveer43, then I am happy to take over!

Deathfireofdoom avatar Nov 27 '23 06:11 Deathfireofdoom

Hi @Deathfireofdoom Could you work with @rajveer43 on this together? Ideally we just want to docker images, the current one as the slim version, and another full version adding necessary dependencies for those databases, or if you think other dependencies are needed we're open to ideas :)

serena-ruan avatar Nov 28 '23 08:11 serena-ruan

Hey I am up for that if @rajveer43 is, dont want to sweep in and steal the issue, if you feel you can do it by yourself feel free to go!

Deathfireofdoom avatar Nov 30 '23 13:11 Deathfireofdoom

Sure @Deathfireofdoom we can work on it together

rajveer43 avatar Nov 30 '23 14:11 rajveer43

Great, we need to:

  • Rename the current docker file to be the slim version
  • Figure out what dependencies that would be useful for the non slim version
  • Make the new dockerfile
  • Update the pipelines

@rajveer43 Do you want to start with figure out the dependencies or the pipelines?

Deathfireofdoom avatar Dec 06 '23 08:12 Deathfireofdoom

I will work on the pipelines

rajveer43 avatar Dec 10 '23 10:12 rajveer43

Any update on this?

Dewwi avatar Dec 22 '23 09:12 Dewwi

have not got time here to work. will resume from this week

rajveer43 avatar Dec 25 '23 17:12 rajveer43

Noticed there hasn't been much progress on this issue. Can I join your team and be able to contribute here?

ghadgeabhi avatar Jan 05 '24 16:01 ghadgeabhi

@rajveer43 how is it going? Are the pipelines ready soon? Should we open a branch to merge our changes? Or maybe you can open a branch I will push my changes.

Deathfireofdoom avatar Jan 30 '24 08:01 Deathfireofdoom

@serena-ruan could you assign this one to me instead? Seems @rajveer43 gone MIA.

I can make the pipelines plus a suggestion on dockerfiles.

Deathfireofdoom avatar Feb 20 '24 07:02 Deathfireofdoom

Heylo! How are we doing on this issue? I have not contributed to MLFlow before, so quite unfamiliar with the pipelines and process but very eager to lend a hand!

aishwaryaprabhat avatar Feb 24 '24 21:02 aishwaryaprabhat

Bumping this issue in hopes of getting it moving. I think there are a lot of people waiting for this change.

StianHanssen avatar Feb 26 '24 13:02 StianHanssen

Hi, @Deathfireofdoom are you working on this? I have a POC for the Dockerfiles, if you have already some work done for the pipelines we can merge them together. Otherwise I am happy to also take that part.

JMLizano avatar Apr 07 '24 16:04 JMLizano

@JMLizano go for it, dont think @rajveer43 will come back, he was suppose to do the pipelines!

Deathfireofdoom avatar Apr 08 '24 03:04 Deathfireofdoom

@serena-ruan I opened a PR for this, it would be great if you can take a look when you have some time, thanks!

JMLizano avatar Apr 14 '24 07:04 JMLizano

any update?

wj-c avatar Jun 21 '24 06:06 wj-c