yocto-gl icon indicating copy to clipboard operation
yocto-gl copied to clipboard

Readme.rst: Docker instrustions still shows v2.2.1

Open david-thrower opened this issue 1 year ago • 9 comments

Willingness to contribute

Yes. I can contribute a documentation fix independently.

URL(s) with the issue

https://github.com/mlflow/mlflow/blob/master/README.rst

Description of proposal (what needs changing)

replace:

docker pull ghcr.io/mlflow/mlflow:v2.2.1

with

docker pull ghcr.io/mlflow/mlflow:v2.7.1

david-thrower avatar Oct 31 '23 19:10 david-thrower

I am new to open source, and I'd like to start my journey by tackling a small issue. Can you please assign me to this issue?

pabitra0011 avatar Oct 31 '23 19:10 pabitra0011

@pabitra0011, I'm not authorized to assign it, but this does look like a perfect contribution to learn the system. I would certainly recommend they do.

david-thrower avatar Oct 31 '23 19:10 david-thrower

@david-thrower Thank you.

pabitra0011 avatar Oct 31 '23 20:10 pabitra0011

@pabitra0011 it's all yours :D

BenWilson2 avatar Nov 01 '23 23:11 BenWilson2

@mlflow/mlflow-team Please assign a maintainer and start triaging this issue.

github-actions[bot] avatar Nov 08 '23 00:11 github-actions[bot]

Hi @BenWilson2, can you please assign me this issue?

DigantGoradia avatar Jan 11 '24 19:01 DigantGoradia

@BenWilson2, I just wanted to confirm which version should this command have?

docker pull ghcr.io/mlflow/mlflow:v2.7.1 or docker pull ghcr.io/mlflow/mlflow:v2.9.2?

DigantGoradia avatar Jan 11 '24 19:01 DigantGoradia

I think if we make this an indication that it's parametrized and then provide the link to where the latest version can be downloaded from, that will suffice :)

BenWilson2 avatar Jan 11 '24 19:01 BenWilson2

@BenWilson2, Command to download the latest version of mlflow is shown in the 3rd line.

echo $CR_PAT | docker login ghcr.io -u USERNAME --password-stdin
# Pull the latest version
docker pull ghcr.io/mlflow/mlflow
# Pull 2.2.1
docker pull ghcr.io/mlflow/mlflow:v2.2.1

The last line in the block is showing info to download specific version.

I'm not clear what is your proposal here. will you help me to understand here?

DigantGoradia avatar Jan 11 '24 21:01 DigantGoradia