Elain T.

Results 77 comments of Elain T.

> > By default, a dropdown should either render a label text of what the dropdown is or one of the options as the selected value (i.e. shipping addresses, render...

How does this component actually handle errors aside from having the `daff-error-message` slot? Do we need to add an error property? Since I need to add error styles to the...

TODO: An opened select should not be tabbable. Tab event needs to be blocked so focus is not lost on select. @griest024

@griest024 Keyboard event handling needs to be added. I've also listed other features that will need to be added too. Keyboard events: - [x] up and down arrow keys increment...

@griest024 There's a weird scrolling behavior if I open the select using Alt + Down key. https://www.loom.com/share/3123202d6ece417f8d2bc4a3e18af75a?sid=2c2c9540-2563-48c8-85ff-1e4d87203151

To do for me: fix conflict, rebase against develop, convert to standalone

Issues - `selectHighlighted` is not updating the selected value - Should `(keydown.arrowdown)="selectNext($event)"` and `(keydown.arrowup)="selectPrevious($event)"` be selecting a value? arrow down and up for native select only opens up the options...

@damienwebdev ready for review

> @xelaint is this permanently open? Or only open upon initial render? I think it should be permanent. If a user is on next.daff.io/docs/packages/cart/extension, and I refresh the page, the...

So if you're on the "Extension" page and decide to refresh to page, you wouldn't want to see that the Extension page is still the selected item in the sidebar?