Dmitry Volyntsev
Dmitry Volyntsev
@drsm >please take a look: >https://gist.github.com/drsm/23a3167637465b48ddb0b82fc5481516 It seems to me that the concept is very straightforward to put any copyrights here.
@drsm > Added fs.mkdir(), fs.rmdir() and friends. BTW, why not support recursive mode also?
@drsm > Added fs.mkdir(), fs.rmdir() and friends. > https://gist.github.com/drsm/4785ae96a8b1ccee27a56c2919d6ba18 Committed, thanks. Also added missing parts for `rename()` method in https://github.com/nginx/njs/commit/0f28a80e9a80b9c7429090e767bf57f19003aed2.
@drsm >Please take a look: > > Improved fs.mkdir() to support recursive directory creation. >https://gist.github.com/drsm/342c4300b17b90cf749f3e316fc3b403 Thanks, committed with some changes. Most notably avoiding any changes to `const char *` memory.
@drsm Take a look, https://gist.github.com/xeioex/cf5d4d451642510777552614ca1396af Coverity (static analyser) found the [following issue ](https://en.wikipedia.org/wiki/Time-of-check_to_time-of-use) with the previous mkdir patch.
@drsm > Improved fs.mkdir() to support recursive directory creation. > https://gist.github.com/drsm/342c4300b17b90cf749f3e316fc3b403 https://gist.github.com/144da2743e6c6230bcb6cddb22ea951d I had to implement `njs_file_tree_walk()` from scratch because ftw.h is a total mess, even though it is a...
@drsm Committed in https://github.com/nginx/njs/commit/f8c8fd850d39915871b2a04bebc9af051766869f, thanks.
@drsm I [added](https://github.com/nginx/njs/commit/7fd2166d01883aca9e2a9df9f65f552ba4196ecc) support for Buffer object in fs module, feel free to catch any issues.
Yes, duplicate of #531.
hi @tommyvn, The promises and async functions are just recently introduced and are not well tested with stream module (unlike http module). I would suggest to start from pure js...