Pavel Yaskevich comments

Results 144 comments of


                                            Pavel Yaskevich

[SE-0461] Replace `@execution(...)` with `@concurrent` and `nonisolated(nonsending)

I don't think we make these backward compatibility guarantees (anymore?) based on conversation with @tshortli about `-interface-compiler-version`.

[SE-0461] Replace `@execution(...)` with `@concurrent` and `nonisolated(nonsending)

These new/old attribute and modifier are not going to be present in old interface files unconditionally anyway.

[SE-0461] Replace `@execution(...)` with `@concurrent` and `nonisolated(nonsending)

For posterity: we discussed this offline and yes, we do need a feature flag here to indicate that new attributes are supported only by new compilers even though we have...

[SE-0461] Replace `@execution(...)` with `@concurrent` and `nonisolated(nonsending)

https://github.com/swiftlang/swift-syntax/pull/3047 @swift-ci please test

[SE-0461] Replace `@execution(...)` with `@concurrent` and `nonisolated(nonsending)

@swift-ci please test source compatibility

[SE-0461] Replace `@execution(...)` with `@concurrent` and `nonisolated(nonsending)

https://github.com/swiftlang/swift-syntax/pull/3047 @swift-ci please test source compatibility

[SE-0461] Replace `@execution(...)` with `@concurrent` and `nonisolated(nonsending)

https://github.com/swiftlang/swift-syntax/pull/3047 @swift-ci please test macOS platform

Init Accessors with nonmutating modify fails to compile

Thanks, I must have missed our reply. I seems like a whack-a-mole here because SIL patterns are not the same and property wrappers don't support this?

Init Accessors with nonmutating modify fails to compile

Currently we don't emit assign_or_init for a modify accessor. I think fixing this is going to mean extending init accessors feature because it currently only supports setters.

Init Accessors with nonmutating modify fails to compile

We might not be running DI on implicitly generated initializers because they are compiler synthesized.