VisualReview icon indicating copy to clipboard operation
VisualReview copied to clipboard

Refer new branches to an existing baseline

Open raboof opened this issue 9 years ago • 3 comments

though that existing baseline is now hard-coded as '2' :)

raboof avatar Jul 08 '16 13:07 raboof

Thanks for the addition @raboof . I've recently fixed the flaky tests on master (was a memory issue on travisCI by the looks of it), so tests are now failing with a good reason. It seems that the branch.clj file is missing. Could you add that one to this PR?

skwakman avatar Jul 15 '16 14:07 skwakman

@skwakman I merged in master and think I fixed a couple of things, but still see test failures - not completely sure how to read them :)

raboof avatar Jul 31 '16 14:07 raboof

Hmm, I suppose still missing are:

  • default to 'master' when no branch name is provided (might be causing the failing tests)
  • select the right baseline instead of hardcoding '2' :)
  • add tests :)

raboof avatar Jul 31 '16 14:07 raboof