twodsix-foundryvtt
twodsix-foundryvtt copied to clipboard
xdy
WIP: feat: add active effects to items
NOT READY FOR MERGE as it depends on the migration PR.
- Please check if the PR fulfills these requirements
- [x] We use semantic versioning (https://github.com/semantic-release/semantic-release to be specific), so follow https://github.com/angular/angular.js/blob/master/DEVELOPERS.md#-git-commit-guidelines
- [ ] Docs have been added / updated (for bug fixes / features)
-
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...) feature
-
What is the current behavior? (You can also link to an open issue here) Previsouly adding a trait did not affect the actor.
-
What is the new behavior (if this is a feature change)? This change makes it so that a trait is an active effect and can change the actor.
-
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?) It comes with a migration to ensure backward compability.
-
Other information: Fix #272
![mergify[bot] avatar](https://avatars.githubusercontent.com/in/10562?v=4 "Published by a pub.dev verified publisher"){kind=small}
Oddly, I'm getting this error when the system initializes. Not certain why. Let me check in the base system.
Just checked with version 1.3.6 - no error
What is this supposed to look like? I'm not certain what the header ("starting with "Attribute Key") does.
At least, there is a localization missing.
When I edit a new effect - I get this warning.
I think it has to do with the color not having an initial value. Is there a way to initialize as black or white when called?
Oddly, I'm getting this error when the system initializes. Not certain why. Let me check in the base system.
Just checked with version 1.3.6 - no error
This has to do with the new dynamic import stuff I'm pretty sure. From the looks of it, I think you have a .DS_Store file in the hooks folder. The dynamic import takes all files in the hooks/template/migrations folder and adds them to the system. For now, try removing the .DS_Store. The proper sollution is to filter out those files in the rollup.config.js script
What is this supposed to look like? I'm not certain what the header ("starting with "Attribute Key") does.
At least, there is a localization missing.
So the three headers there were supposed to be the same as if you go into the active effect and add effects.
When I edit a new effect - I get this warning.
I think it has to do with the color not having an initial value. Is there a way to initialize as black or white when called?
Hm, what is it that should have a color? the item or the active effect? or something else?
Yes, it is when I put the edit effect button.
When the window opens the tint color is blank. If it is set to something the warning message doesn't appear.
.DS_Store
Hmm...I can't find this file in the folder - or anywhere when I search - except for another program
https://github.com/xdy/twodsix-foundryvtt/pull/762#issuecomment-1004862469 Fixed by initializing tint & name on create new effect and drag-drop
It's a hidden file so in Finder you have to enable to show hidden files. In the terminal use the command ls -al to see hidden files
On Jan 4, 2022, 10:53 -0500, marvin9257 @.***>, wrote:
.DS_Store Hmm...I can't find this file in the folder - or anywhere when I search - except for another program — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: @.***>
This pull request introduces 1 alert when merging 9f75ba96c7e152a4338f032bbff211c6c87d98e4 into 6ddb9a14fba1f60be3cb25d1147412d565f37fe0 - view on LGTM.com
new alerts:
- 1 for Unused variable, import, function or class
![lgtm-com[bot] avatar](https://avatars.githubusercontent.com/in/17324?v=4 "Published by a pub.dev verified publisher"){kind=small}
I went through the Active effects PR and it looks great. I pushed a commit with some suggested styling tweaks. I also fixed a missing label for the effect on create. One thing I noticed it that if the item is dropped into a ship's locker, the active effect can't be edited. Is that the desired function? (duplicate message from discord)