xdp-tutorial icon indicating copy to clipboard operation
xdp-tutorial copied to clipboard

Typo in parsing_helpers.h

Open MarcusWichelmann opened this issue 3 years ago • 1 comments

Just spooted a typo in your parsing_helpers.h which breaks you bounds check for parsing ipv4 packets. https://github.com/xdp-project/xdp-tutorial/blob/master/common/parsing_helpers.h#L163 should be sizeof(*iph)

Reporting, in case you wanna fix it. 😄

MarcusWichelmann avatar Mar 05 '21 09:03 MarcusWichelmann

Marcus Wichelmann [email protected] writes:

Just spooted a typo in your parsing_helpers.h which breaks you bounds check for parsing ipv4 packets. https://github.com/xdp-project/xdp-tutorial/blob/master/common/parsing_helpers.h#L163 should be sizeof(*iph)

Reporting, in case you wanna fix it. 😄

Thank you for the report! Turns out there were actually two of these errors in that file, will fix both :)

tohojo avatar Mar 05 '21 13:03 tohojo