vscode-php-debug icon indicating copy to clipboard operation
vscode-php-debug copied to clipboard

feat: Add support for runInTerminal request

Open zobo opened this issue 1 year ago • 4 comments

Support for console option with internalConsole, integratedTerminal and externalTerminal options

zobo avatar Jun 30 '24 23:06 zobo

Codecov Report

:x: Patch coverage is 26.00000% with 37 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 65.34%. Comparing base (e2231bc) to head (ba1289b). :warning: Report is 24 commits behind head on main.

Files with missing lines Patch % Lines
src/terminal.ts 19.23% 21 Missing :warning:
src/phpDebug.ts 27.27% 16 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #966      +/-   ##
==========================================
- Coverage   66.35%   65.34%   -1.01%     
==========================================
  Files          16       16              
  Lines        2122     2167      +45     
  Branches      437      453      +16     
==========================================
+ Hits         1408     1416       +8     
- Misses        714      751      +37     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 30 '24 23:06 codecov[bot]

The dilemma here is that it's not trivial to track the spawned process and catch the exit event - and kill the right process.

zobo avatar Jul 01 '24 00:07 zobo

Very useful feature!

I use it in NVIM, but the window on the right is always empty ("DAP Console") изображение

mature-woman avatar May 13 '25 09:05 mature-woman

Yeah, as said, there are some tricky parts to this. I'll probably implement it in a way that you have to explicitly use it via the console setting https://code.visualstudio.com/docs/debugtest/debugging-configuration#_launchjson-attributes

zobo avatar May 13 '25 09:05 zobo

:tada: This PR is included in version 1.37.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Aug 09 '25 12:08 github-actions[bot]

Thank you

mature-woman avatar Aug 09 '25 12:08 mature-woman