vscode-php-debug icon indicating copy to clipboard operation
vscode-php-debug copied to clipboard

ci: Ability to open a browser when the debug session is created

Open letynsoft opened this issue 6 years ago β€’ 8 comments

Adds launch option which allows setting the command to run and the URL to open (to open a browser) with the xdebug query param to start the debugging session

letynsoft avatar Oct 12 '18 19:10 letynsoft

Codecov Report

Merging #315 into master will decrease coverage by 0.31%. The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #315      +/-   ##
==========================================
- Coverage   70.05%   69.74%   -0.32%     
==========================================
  Files           5        5              
  Lines        1012     1028      +16     
  Branches      161      163       +2     
==========================================
+ Hits          709      717       +8     
- Misses        303      311       +8
Impacted Files Coverage Ξ”
src/phpDebug.ts 66.26% <37.5%> (-0.54%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 047777b...af056c8. Read the comment docs.

codecov[bot] avatar Oct 12 '18 20:10 codecov[bot]

Hi, i will implement the other things you menthined, but when i try to add the open module it just wont create the packages-lock.jsosn file (which seems to be neerded for the checking stuff), can you help me with that (tried simple npm install --save open, but as i say, doesn't update the lock file)? Also not sure what you mean with the camel case one, but i guess, once i figure out the open package, it will only need a string URL there

letynsoft avatar Oct 15 '18 21:10 letynsoft

Are you running at least node 8 and npm 6?

felixfbecker avatar Oct 15 '18 21:10 felixfbecker

And of course it does update it now... :-/ so you were probably right and it didn;t work until reboot ... ok will do the other things now... so don't bother :)

letynsoft avatar Oct 17 '18 20:10 letynsoft

Hi, So i have updated the feature. Let me know your thoughts :)

letynsoft avatar Oct 17 '18 21:10 letynsoft

Hi, Another update... Seems i didn't notice the first open should have been opn in the commit title :-/

letynsoft avatar Oct 21 '18 21:10 letynsoft

Any news here? :)

letynsoft avatar Nov 21 '18 21:11 letynsoft

Hi @letynsoft @felixfbecker This is an excellent step forward. I've just tried to implement a simple solution using the "program" and "args" properties but it stops debugging when the "program" script ends.

Any idea on when you might get this completed, it's a feature I would really like to see. I've just moved back to VSC from NetBeans which had a pretty good config for doing this and I'm missing it already.

As an aside, could you also add something along the lines of "program" (very weird choice of parameter name for script) and "args" that does not terminate the debug session which it finishes? Maybe an "init" object with "program" or "script" and "args" that are run when the debugger is started. This would allow platform specific code to run via exec which could open a browser (start http://.... on Windows) or all manner of other funky stuff.

ianef avatar Mar 08 '19 18:03 ianef