selection-sharer icon indicating copy to clipboard operation
selection-sharer copied to clipboard

Facebook

Open pepaulo opened this issue 9 years ago • 6 comments

Don't show the select text to share. Show only the URL config on fb:ID and not the select text of page.

Thank you for the great tool.

pepaulo avatar May 24 '15 01:05 pepaulo

Had the same issue. This script uses facebooks share dialgue which is only meant for sharing URL's and other opengraph posts (https://developers.facebook.com/docs/sharing/reference/share-dialog). The Feed dialogue however supports sharing text snippets, which is what we are looking for (https://developers.facebook.com/docs/sharing/reference/feed-dialog/v2.3).

I changed it to this instead (line 234):

var url = 'https://www.facebook.com/dialog/feed?' + 'app_id='+self.appId + '&display=popup'+ '&caption='+encodeURIComponent(text)+ '&link='+encodeURIComponent(self.url2share)+ '&href='+encodeURIComponent(self.url2share)+ '&redirect_uri='+encodeURIComponent(self.url2share);

This fixed it for me.

Riaan-ZA avatar Jun 22 '15 12:06 Riaan-ZA

Thank you. This solved the problem for me too. Good job.

pepaulo avatar Jun 23 '15 00:06 pepaulo

@PlatinumSeed Can you submit a pull request and I'll merge it so that everyone can benefit from this change. Thanks!

xdamman avatar Jun 23 '15 03:06 xdamman

https://github.com/xdamman/selection-sharer/pull/19

Riaan-ZA avatar Jun 23 '15 06:06 Riaan-ZA

People who have subscribed to this issue may be interested in the following relevant changes I have made to use the "description" instead of the "caption", described here in issue https://github.com/xdamman/selection-sharer/issues/31

dm-coding avatar Oct 16 '15 10:10 dm-coding

Have the same problem. :(

skazhikadyadya avatar Jan 12 '17 13:01 skazhikadyadya