Custom-JavaScript-for-Websites-2 icon indicating copy to clipboard operation
Custom-JavaScript-for-Websites-2 copied to clipboard

Published 20 hours ago • verified publisher icon xcv58

The way we handle extra scripts is broken!

Open xcv58 opened this issue 7 years ago • 1 comments

related to #44

The replace ; to \n and join back is breaking the workflow, details:

https://github.com/xcv58/Custom-JavaScript-for-Websites-2/blob/8a9427ebec2eacaae78fae0ed5b49963930829bd/src/js/stores/IncludeStore.js#L3-L4

https://github.com/xcv58/Custom-JavaScript-for-Websites-2/blob/8a9427ebec2eacaae78fae0ed5b49963930829bd/src/js/run.js#L39-L43

xcv58 avatar Mar 03 '18 18:03 xcv58

We should move the external scripts to a list of string instead of pure text.

And we need a warning message for users with valid external scripts to migrate to the new way.

xcv58 avatar Mar 03 '18 18:03 xcv58