Xavier Claessens
Xavier Claessens
Oh, we already have a PR: https://github.com/mesonbuild/meson/pull/8499.
For the unit test you don't need to copy everything, just extend existing unit test, it saves CI running time.
This is needed for g-ir-scanner to find pkg-config there: https://gitlab.gnome.org/GNOME/gobject-introspection/-/blob/main/giscanner/pkgconfig.py#L30.
Since lots of things changed and I had a PR already that touch this code, I included a similar fix into https://github.com/mesonbuild/meson/pull/12126.
> This doesn't work since `find_external_program` does not finds correctly pkg-config > `PkgConfigDependency.search_pkgbin` should do the equivalent to `find_program('pkg-config')` I'm writing a unit test for that, and you were right....
> I'm writing a unit test for that, and you were right. I'll try to find a solution. It's actually way too complicated to get it working through override_find_program(), the...
@dabrain34 yeah, saw that in the CI too... fixed now.
@dabrain34 argh, a typo, fixed now.
> Looks like this just needs a review? yes please > Unfortunately the bug still happens on my windows setup where pkconfig finds the pc file for glib but the...