Xavier Claessens comments

Results 106 comments of


                                            Xavier Claessens

Subprojects are not included in tarball, when behind a disabled option

I guess we could keep `--include-subprojects` with no extra argument to only include subprojects that have been used for current setup, and extend the syntax to `--include-subprojects foo,bar` to only...

Subprojects are not included in tarball, when behind a disabled option

Note that the original use-case for --include-subprojects is to make a specific build reproductible. For example when configuring GStreamer for a specific device we want to be able to ship...

Subprojects are not included in tarball, when behind a disabled option

@evelikov I guess we can add `--include-subprojects *` or `all`. PR welcome ;-)

cleanup interpreter implementation of both_libraries a bit

LGTM

mlog: set LESS environment variable for pager.

LGTM

mlog: set LESS environment variable for pager.

CI failures seems unrelated, LGTM.

1.4.0 breaks cross-compilation of Mesa (Rust w/ proc-macro use linked into library)

That's probably related to https://github.com/mesonbuild/meson/pull/12917. Can you try reverting it?

1.4.0 breaks cross-compilation of Mesa (Rust w/ proc-macro use linked into library)

ah sorry, I see at the bottom of your report that you did that already.

1.4.0 breaks cross-compilation of Mesa (Rust w/ proc-macro use linked into library)

A test case would be a good first step. The thing is https://github.com/mesonbuild/meson/pull/12917 comes with a test case that shows that PR is needed, so a simple revert is unlikely...

meson dist --include-subprojects should apply diff_files from wrap

It should have included the patch file in the tarball and it will be applied when the subproject is used. Does that work?