xchainjs-lib icon indicating copy to clipboard operation
xchainjs-lib copied to clipboard

FIX: gaslimit estimate for withdrawl underestimates the gas by 29x

Open mikewyszinski opened this issue 2 years ago • 1 comments

discord conversation: https://discord.com/channels/838986635756044328/974028719435952208

Fix: in deposit()

check to see if there is a memo defined,
if there is a memo  
      if memo is type  withdrawal
          use a gas mutliplier = 50
      else 
         use default gas multiplier

mikewyszinski avatar May 11 '22 23:05 mikewyszinski

@mikewyszinski Don't use another hardcoded multiplier - this value needs to be changed over time as well, similar to hardcoded gas limit we had in xchain-thorchain before. See ongoing discussion at Discord https://discord.com/channels/838986635756044328/974028719435952208/974263213543788544

veado avatar May 12 '22 10:05 veado

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

github-actions[bot] avatar Sep 20 '23 02:09 github-actions[bot]