xchainjs-lib icon indicating copy to clipboard operation
xchainjs-lib copied to clipboard

Published 20 hours ago • verified publisher icon xchainjs

Add getting internal tx for ETH

Open osabl opened this issue 2 years ago • 2 comments

Just getting internal tx for ETH for getTransaction method

osabl avatar May 06 '22 16:05 osabl

@osabl 2 general comments:

  1. tests are failing on this branch, will need to fix before merging
  2. i'm thinking this change may confuse anyone using this library already because now internal txs will be displayed when they weren't prior. Should we consider NOT combining internalTXs in the getTransactions() call and expose getETHInternalTransactionHistory() publically instead?

mikewyszinski avatar May 09 '22 04:05 mikewyszinski

@osabl Friendly ping. Pls check comment above to fix your PR.

veado avatar May 18 '22 16:05 veado