xchainjs-lib icon indicating copy to clipboard operation
xchainjs-lib copied to clipboard

Published 20 hours ago • verified publisher icon xchainjs

Return 0 balances everywhere

Open severinwullschleger opened this issue 3 years ago • 5 comments

getBalance should always return an array at least containing the mainAsset of a chain.

ETH, BTC; BCH and LTC are already behaving like that.

I added the same behaviour to RUNE and BNB. adjusted the clients cosmos, thorchain and binance

severinwullschleger avatar Jun 25 '21 14:06 severinwullschleger

@severinwullschleger Last change request: Pls bump versions in package.json of each xchain-* packages you have updated and add a note to CHANGELOG. After bumping + merging your PR we will published these updated packages to npm then. Thx!

veado avatar Jun 28 '21 16:06 veado

@veado did that

severinwullschleger avatar Jun 30 '21 10:06 severinwullschleger

@veado fixed the conflicts, can you merge it?

severinwullschleger avatar Jul 26 '21 09:07 severinwullschleger

Is it going to be merged?

matikucharski avatar Mar 31 '22 09:03 matikucharski

Is it going to be merged?

Conflicts need to be fixed before going to merge, anyone?

veado avatar Apr 04 '22 06:04 veado