rn-pdf-reader-js icon indicating copy to clipboard operation
rn-pdf-reader-js copied to clipboard

Published 20 hours ago • verified publisher icon xcarpentier

Pr fix

Open xcarpentier opened this issue 1 year ago • 3 comments

xcarpentier avatar Oct 28 '23 18:10 xcarpentier

@xcarpentier can we get this merged? need help?

victoralmeidadev avatar Nov 06 '23 17:11 victoralmeidadev

I'd love to see Android working again, have had to revert to a new system

GrahamEvans31 avatar Nov 24 '23 05:11 GrahamEvans31

I tried installing the library with the changed package name (@valli_/rn-pdf-reader-js instead of rn-pdf-reader-js) and it threw an error at build time, on both platforms, using Expo's eas build:

iOS

image

Android

image

How can this be fixed in the forked repo? I wanted to post an issue on Valli-'s fork repo, but he has Issues disabled. And I can't mention him here either.

I could fork his fork and make the correction myself (I'd need to confirm that changing the package name is the only issue), but would that be ok? I have a hunch it might seem unethical.

Zcehtro avatar Feb 02 '24 14:02 Zcehtro