xchen
xchen
Debugging found that when switching sequence display, viewportsWithAnnotations has the previous viewportId, but getAnnotations(this.getToolName(), viewport.element); It's empty. see: https://github.com/cornerstonejs/cornerstone3D/blob/main/packages/tools/src/tools/ScaleOverlayTool.ts#L115C12-L115C36 https://github.com/cornerstonejs/cornerstone3D/blob/main/packages/tools/src/tools/ScaleOverlayTool.ts#L186C25-L186C78 test image: [2.25.298238216209691961446416391631262236725.zip](https://github.com/user-attachments/files/23927177/2.25.298238216209691961446416391631262236725.zip)
I tested this pull request #2504 and it did not encounter any errors, but some images still cannot display the scale overlay tool. This is normal in the cornerstoneTool library,...
Two issues were identified: 1. Some images cannot display the scale overlay tool 2. When switching between series displays, the scale overlay tool cannot be updated and can only display...
> we need data to test this, can you provide anonymized data [S0001.zip](https://github.com/user-attachments/files/23979945/S0001.zip) [S0002.zip](https://github.com/user-attachments/files/23979946/S0002.zip) 1. For S0001, The ` cornerstoneTool` library can display normally ScaleOverlayTool. But `cornerstone3D/tools` library cannot display...
This change did not fix the actual problem #2504 @jbocce