[WIP][v22][Video] Improve user experience when playing movies/episodes from Bluray ISO/BDMV.

[78andyp]

This is another attempt at #24277 using @rmrector's advice about the VFS.

When a movie/episode is played from an ISO/BDMV an additional file is added files table and this is linked to the movies or episodes entry.

I've also fixed the way Play from Here works (or didn't work) for ISOs/BDMVs - by properly removing duplicates.

This is still a work in progress but I would like feedback on the implementation and any perceieved problems.

It doesn't require any database changes (unlike the first attempt).

Description

Motivation and context

How has this been tested?

Locally

What is the effect on users?

Base Having just refreshed from scraper - no details shown and duration from scraper.

Before Having just watched episode 1 - the details for both Episodes 1 and 2 (both on first ISO) have changed.

After Having just watched episode 1 - only episode 1 has changed

Then watching episode 2 - only 2 has changed and 1 is preserved.

Screenshots (if appropriate):

Types of change

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] Clean up (non-breaking change which removes non-working, unmaintained functionality)
• [X] Improvement (non-breaking change which improves existing functionality)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that will cause existing functionality to change)
• [ ] Cosmetic change (non-breaking change that doesn't touch code)
• [ ] Student submission (PR was done for educational purposes and will be treated as such)
• [ ] None of the above (please explain below)

Checklist:

• [ ] My code follows the Code Guidelines of this project
• [ ] My change requires a change to the documentation, either Doxygen or wiki
• [ ] I have updated the documentation accordingly
• [ ] I have read the Contributing document
• [ ] I have added tests to cover my change
• [ ] All new and existing tests passed

[78andyp]

I only checked the code style and didn't check the actual functionality.

Thanks for the feedback.

[neo1973]

Please squash the rebase fixes, apply the formatting changes and I'll merge this :slightly_smiling_face:

[78andyp]

Please squash the rebase fixes, apply the formatting changes and I'll merge this 🙂

Brilliant, thanks. All done.

Any chance we could get #24794 (folder stacks) in as well?? As that would provide a good base for me to finish off #24304 - as that will need tweaks once both the first two are in (especially for DVDs - the vast majority of the work for that is already done in #24997) as that would then mean those using discs have almost the same seamless experience as those using files. The only remaining work would be around movie versions (ie. handling two versions on one disc - which would need some work with @ksooo and @CrystalP).

Edit - by as welll I mean after this one and I've reconfirmed that they play together nicely.

Thanks Andy

[ksooo]

Sorry that I missed to review this PR before it was merged. I really would like to ask @78andyp to take a look at my comments here https://github.com/xbmc/xbmc/commit/54a63d02f1e63ebad0cd99dc06ca070c91ceb93c and to proof whether some of them can be addressed in a follow-up PR. Thanks.

[78andyp]

Sorry that I missed to review this PR before it was merged. I really would like to ask @78andyp to take a look at my comments here 54a63d0 and to proof whether some of them can be addressed in a follow-up PR. Thanks.

More than happy to. Let me just finish on folder stacks as I've got my head around that (and I'll ask you to review that when done) and I'll come back to this. Thanks for your comments.