xbmc icon indicating copy to clipboard operation
xbmc copied to clipboard

allow ff/rw when paused

Open gt945 opened this issue 3 years ago • 2 comments

Description

  1. allow ff/rw when paused
  2. remove code never be called

Motivation and context

fix #15671

How has this been tested?

  1. play a video
  2. pause
  3. press fastforward or fastrewind button

What is the effect on users?

Screenshots (if appropriate):

Types of change

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] Clean up (non-breaking change which removes non-working, unmaintained functionality)
  • [x] Improvement (non-breaking change which improves existing functionality)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that will cause existing functionality to change)
  • [ ] Cosmetic change (non-breaking change that doesn't touch code)
  • [ ] None of the above (please explain below)

Checklist:

  • [x] My code follows the Code Guidelines of this project
  • [ ] My change requires a change to the documentation, either Doxygen or wiki
  • [ ] I have updated the documentation accordingly
  • [x] I have read the Contributing document
  • [ ] I have added tests to cover my change
  • [ ] All new and existing tests passed

gt945 avatar Jul 12 '22 11:07 gt945

Not sure, but for me it seems that the check for not paused you removed was there by intention.

ksooo avatar Jul 12 '22 13:07 ksooo

I've made some formatting changes to meet the current code style. The diffs are available in the following links:

For more information please see our current code style guidelines.

jenkins4kodi avatar Jul 13 '22 07:07 jenkins4kodi

@gt945 this needs a rebase

jenkins4kodi avatar Sep 22 '22 17:09 jenkins4kodi