[RFC] HDMI CEC volume control

[V10lator]

Description

This is a completely untested PoC to fix https://forum.kodi.tv/showthread.php?tid=211527

I added a new action ID and hacked it quick & dirty into existing infrastructure.

Motivation and Context

It solves the 3 year old feature request at https://forum.kodi.tv/showthread.php?tid=211527

How Has This Been Tested?

I did not test it as compiling is too much for the machine I'm working with.

Screenshots (if appropriate):

Types of change

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] Clean up (non-breaking change which removes non-working, unmaintained functionality)
• [X] Improvement (non-breaking change which improves existing functionality)
• [X] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that will cause existing functionality to change)
• [ ] Cosmetic change (non-breaking change that doesn't touch code)
• [ ] None of the above (please explain below)

Checklist:

• [X] My code follows the Code Guidelines of this project
• [ ] My change requires a change to the documentation, either Doxygen or wiki
• [ ] I have updated the documentation accordingly
• [X] I have read the Contributing document
• [ ] I have added tests to cover my change
• [ ] All new and existing tests passed

[aanderse]

Would this patch allow me to detect volume up and down presses on my TV remote control and adjust the volume of kodi accordingly? If so, I'm happy to cherry pick this patch into my kodi instances and test.

[V10lator]

Would this patch allow me to detect volume up and down presses on my TV remote control and adjust the volume of kodi accordingly?

No, it's the other way around.

[jenkins4kodi]

@V10lator this needs a rebase

[github-actions[bot]]

This pull request is now marked stale because it has been open over a year without activity. Remove the stale label or add a comment to reset the stale state.

[malard]

@opdenkamp can we get this implemented when we have time please? :)

[garbear]

I'm not against the feature but we're short on manpower (untagging inactive [but still current] team members) so if you're willing to polish the PR, including runtime testing, we can consider getting it in. I have a CEC device to test with but I'm also a bit limited on time also.

[malard]

retagging both me and opdenkamp, given I employ lars and wish to effectively fund this addition :) it's ultimately good for me and Pulse-Eight with the CEC Adapter sales, cheers!

[github-actions[bot]]

This pull request is now marked stale because it has been open over a year without activity. Remove the stale label or add a comment to reset the stale state. This pull request will be closed in 30 days if no activity is detected.

[garbear]

Any appetite to complete the PR? If not by the author either @malard or his minion?

Also @malard We want to link P8 in our 22 alpha 1 release notes, if you want a URL, post it here or in https://github.com/xbmc/blog/issues/113.