[Script.extendedinfo@matrix] 6.0.1

[scott967]

Description

Checklist:

• [x] My code follows the add-on rules and piracy stance of this project.
• [x] I have read the CONTRIBUTING document
• [x] Each add-on submission should be a single commit with using the following style: [script.foo.bar] 1.0.0

Additional information :

• Submitting your add-on to this specific branch makes it available to any Kodi version equal or higher than the branch name with the applicable Kodi dependencies limits.
• add-on development wiki page.
• Kodi pydocs provide information about the Python API
• PEP8 codingstyle which is considered best practise but not mandatory.
• This add-on repository has automated code guideline check which could help you improve your coding. You can find the results of these check at Codacy. You can create your own account as well to continuously monitor your python coding before submitting to repo.
• Development questions can be asked in the add-on development section on the Kodi forum.

This is a reboot of script.extendedinfo currently in repo-scripts. I have been unable to contact original author Phil65; however, I do not believe he is active at this time.

The main purpose of this release is to update it for use in Kodi Matrix/Nexus including python3 compatibility. However, due to various changes required due to changes in the online data sources since this addon was last updated I have had to make numerous updates including but not limited to:

• update dependency on script.module.kodi65 to script.module.kutils
• add settings for user-supplied api keys
• adjust some api calls
• remove support for bandsintown (addon not eligible for api key per site TOU)
• refactor code to PEP8
• add doctrings (WIP)
• change ownership to scott967

To facilitate review I have provided 2 commits:

1. all changes up to last version in phil65 source (5.6.0) note: slight discrepancy with repo-scripts
2. my changes from 5.6.0

If needed these can be squashed.

[basrieter]

@phil65 are you OK with this new version?

[scott967]

Any chance getting a review on this?

[scott967]

I made some minor changes, adding some docstrings and type annotations and in a couple places changed string formatting to f-strings to improve readability. Then squashed all into a single commit.

[basrieter]

I made some minor changes, adding some docstrings and type annotations and in a couple places changed string formatting to f-strings to improve readability. Then squashed all into a single commit.

I would still like an OK from the original author: @phil65

[thezoggy]

I made some minor changes, adding some docstrings and type annotations and in a couple places changed string formatting to f-strings to improve readability. Then squashed all into a single commit.

I would still like an OK from the original author: @phil65

you've asked for an OK from the original author for 2+ months now.. what is the max limbo time to wait?

[thezoggy]

saw that this landed, went to go update and it says it failed for kutils:

2022-11-28 19:33:42.447 T:9713    ERROR <general>: CCurlFile::Open failed with code 0 for https://ftp.heanet.ie/mirrors/xbmc/addons/matrix/script.module.kutils/script.module.kutils-1.3.0.zip:
                                                   
2022-11-28 19:33:42.449 T:9713    ERROR <general>: CAddonInstallJob[script.module.kutils]: failed to download special://home/addons/packages/script.module.kutils-1.3.0.zip
2022-11-28 19:33:42.452 T:9713    ERROR <general>: CAddonInstallJob[script.extendedinfo]: failed to install dependency script.module.kutils
2022-11-28 19:34:05.160 T:9195     INFO <general>: Samba is idle. Closing the remaining connections
2022-11-28 19:34:56.525 T:9195     INFO <general>: Loading skin file: DialogConfirm.xml, load type: KEEP_IN_MEMORY
2022-11-28 19:35:04.150 T:9195  WARNING <general>: CGUIMediaWindow::OnMessage - updating in progress
2022-11-28 19:35:11.221 T:9709     INFO <general>: CAddonMgr::FindAddon: resource.images.studios.white v0.0.30 installed
2022-11-28 19:36:16.268 T:10006    INFO <general>: CAddonMgr::FindAddon: script.module.kutils v1.3.0 installed
2022-11-28 19:36:18.142 T:10006    INFO <general>: CAddonMgr::FindAddon: script.extendedinfo v6.0.1 installed

then when starting extendedinfo

2022-11-28 20:21:55.886 T:11625   ERROR <general>: EXCEPTION: Unknown addon id 'plugin.program.autocompletion'.
2022-11-28 20:21:55.893 T:11625   ERROR <general>: EXCEPTION Thrown (PythonToCppException) : -->Python callback/script returned the following error<--
                                                    - NOTE: IGNORING THIS CAN LEAD TO MEMORY LEAKS!
                                                   Error Type: <class 'RuntimeError'>
                                                   Error Contents: Unknown addon id 'plugin.program.autocompletion'.
                                                   Traceback (most recent call last):
                                                     File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/script.extendedinfo/plugin.py", line 14, in <module>
                                                       from kutils import addon, utils
                                                     File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/script.module.kutils/lib/kutils/__init__.py", line 15, in <module>
                                                       from kutils.dialogbaselist import DialogBaseList
                                                     File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/script.module.kutils/lib/kutils/dialogbaselist.py", line 12, in <module>
                                                       from kutils.t9_search import T9Search
                                                     File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/script.module.kutils/lib/kutils/t9_search.py", line 17, in <module>
                                                       import AutoCompletion
                                                     File "/storage/emulated/0/Android/data/org.xbmc.kodi/files/.kodi/addons/script.module.autocompletion/lib/AutoCompletion.py", line 21, in <module>
                                                       PLUGIN_ADDON = xbmcaddon.Addon(PLUGIN_ID)
                                                   RuntimeError: Unknown addon id 'plugin.program.autocompletion'.
                                                   -->End of Python script error report<--

2022-11-28 20:21:10.338 T:11444    INFO <general>: CAddonMgr::FindAddons: resource.images.studios.white v0.0.30 installed
2022-11-28 20:21:10.340 T:11444    INFO <general>: CAddonMgr::FindAddons: script.extendedinfo v6.0.1 installed
...
2022-11-28 20:21:10.340 T:11444    INFO <general>: CAddonMgr::FindAddons: script.module.autocompletion v2.1.1 installed
2022-11-28 20:21:10.355 T:11444    INFO <general>: CAddonMgr::FindAddons: script.module.kutils v1.3.0 installed

[scott967]

Please submit support requests in Kodi skin development forum If kutils or any other addon fails to install from mirrors, retry later. The exception in kutils is due to an update ver 2.1.1 of script.module.autocompletion which is not backward compatible and breaks addons which use that script. I have submitted a PR to the author that should fix it. In the meantime a work around is to install plugin.program.autocompletion from the Kodi repo "programs" addon node. Alternative is to roll back script.module.autocompletion to ver 2.0.6.