repo-plugins icon indicating copy to clipboard operation
repo-plugins copied to clipboard

[plugin.video.catchuptvandmore@matrix] 0.2.38+matrix.1

Open joaopa00 opened this issue 2 years ago • 3 comments

  • [x] My code follows the add-on rules and piracy stance of this project.
  • [x] I have read the CONTRIBUTING document
  • [x] Each add-on submission should be a single commit with using the following style: [plugin.video.foo] v1.0.0

Once more, this PR is pretty huge. If this PR is merged very quickly, I will send the newest version very soon. So, the PR for the next coming version 0.2.39 should be relatively small, so easier to review.

Thanks for your understanding.

joaopa00 avatar Oct 01 '22 18:10 joaopa00

I removed the problematic feature. Thank you for the review and the feedback.

(Not so) unrelated note: I pushed some logos and picture in the repository repo-resources. Can you merge them?

joaopa00 avatar Oct 06 '22 01:10 joaopa00

Thank you for the feedback. I will send the library for enum to repo-scripts soon.

joaopa00 avatar Oct 11 '22 08:10 joaopa00

I sent a PR to repo-scripts to merge enum. Once that's done, I shall update this PR to take advantage of this feature.

joaopa00 avatar Oct 11 '22 09:10 joaopa00

I removed the dependency on enum. Please, have a look again.

joaopa00 avatar Oct 22 '22 18:10 joaopa00

All the requested changes were done. Is it possible to have a new feedback? Thanks in advance?

joaopa00 avatar Oct 31 '22 01:10 joaopa00

What should I do more to have a review, please?

joaopa00 avatar Dec 09 '22 15:12 joaopa00

I will check tonight.

basrieter avatar Dec 09 '22 17:12 basrieter

Thanks

joaopa00 avatar Dec 09 '22 17:12 joaopa00

Thanks. All looking good too me now. @pkscout do you agree?

basrieter avatar Dec 10 '22 22:12 basrieter

Thanks for the review. I proposed a PR in repo/resources that looks staled too. Can you merge it too, please?

joaopa00 avatar Dec 11 '22 06:12 joaopa00

Thanks for the review. I proposed a PR in repo/resources that looks staled too. Can you merge it too, please?

Which one?

basrieter avatar Dec 11 '22 15:12 basrieter

I merged it already

enen92 avatar Dec 11 '22 17:12 enen92

Thank you very much to everyone for the feedbacks and merging this PR!!

joaopa00 avatar Dec 11 '22 17:12 joaopa00