inputstream.adaptive icon indicating copy to clipboard operation
inputstream.adaptive copied to clipboard

Error compiling for tvOS - deprecated functions in lib/cdm/cdm/base/native_library_mac.mm

Open WugtheFlunk opened this issue 1 year ago • 3 comments

Describe the problem

LoadNativeLibrary function on line 45 has portion of code on line 77:

native_lib->bundle_resource_ref` = CFBundleOpenBundleResourceMap(bundle);

Similarly, UnloadNativeLibrary function on line 83 has deprecated function on lines 88 & 89:

      CFBundleCloseBundleResourceMap(library->bundle,
                                     library->bundle_resource_ref);

These functions are not available in tvOS and they are deprecated in macOS as of version 10.15.

More info here: https://developer.apple.com/documentation/corefoundation/1537133-cfbundleclosebundleresourcemap?language=objc

Possible fix

No response

Steps to reproduce

No response

Debug log

No Kodi log because this is a compilation issue.

Stream manifest file(s)

No response

Additional info

No response

Operating system(s)

Apple (tvOS)

Operating system version(s)

No response

InputStream Adaptive version(s)

21.4.10

Kodi version(s)

N/A - Build issue.

WugtheFlunk avatar Jun 27 '24 00:06 WugtheFlunk

i made a PR #1593 but idk if changes are right because idk apple enviroment and its needed test these changes

are you able to build and test it on osx and tvos? if so please read "How has this been tested" section on PR

CastagnaIT avatar Jun 30 '24 10:06 CastagnaIT

now that i think about it better my pr its not full correct because yes it check at build condition, but not in a running enviroment

CastagnaIT avatar Jun 30 '24 10:06 CastagnaIT

can you post the complete sequence of commands that you use to build ISA?

i was looking again, but on our CI buildings i dont see this problem on tvOS the lib/cdm folder should not be built because the system (darwin_embedded) is excluded

https://github.com/xbmc/inputstream.adaptive/blob/7d72e7cf3d7ffb78c4e833d32f1f3df2a25627aa/src/decrypters/CMakeLists.txt#L15

so my suspect is that you are using a different way to build it

CastagnaIT avatar Aug 19 '24 15:08 CastagnaIT

closed due to no response

CastagnaIT avatar Mar 26 '25 13:03 CastagnaIT