chorus2 icon indicating copy to clipboard operation
chorus2 copied to clipboard

Published 20 hours ago • verified publisher icon xbmc

Bug fixes on some translations and compilations

Open pbodq2 opened this issue 4 years ago • 3 comments

pbodq2 avatar Jan 27 '21 00:01 pbodq2

#433

More information about "Fix ECO template compilation errors", these errors do not occur in author's Docker's container environment, i.e. node.js v8.12.0 npm v6.4.1

We can reproduce them in newer versions like node.js v14.15.4 npm v6.14.10 (all other package versions keep constant)

You guys may consider whether it is necessary to adopt it or leave it unchanged for better consistency.

pbodq2 avatar Jan 28 '21 15:01 pbodq2

@gade01 now that this is translatable via weblate can you do the follow up to this issue and close it?

enen92 avatar Mar 12 '22 09:03 enen92

@enen92 Yeah, language files should now be left out of this PR. But I can see other stuff is changed as well, which probably should be left open and reviewed.

@pbodq2 Changes to these files are no longer needed as they are superseeded by https://github.com/xbmc/chorus2/pull/455

gade01 avatar Mar 12 '22 09:03 gade01