addon-check icon indicating copy to clipboard operation
addon-check copied to clipboard

Published 20 hours ago • verified publisher icon xbmc

Log file generates a warning when --reporter=log is used

Open thombet opened this issue 4 years ago • 5 comments

When I run kodi-addon-checker --branch leia --reporter=log there is a warning reported on the log file generated by the addon-checker:

WARN: Found non whitelisted file ending in filename ./plugin.video.imagotv/kodi-addon-checker-report.log
WARN: We found no problems and 1 warnings, please check the logfile.

I think it is wrong and this file should somehow be ignored. It seems it was already reported in #156 but from what I see in the final answer the reporter closed the issue because he/she didn't use the argument reporter=loganymore which doesn't really fix the initial issue.

I didn't look in the code yet so I don't know how easy it could be fixed but could you first confirm if it is a bug or if it is somehow expected?

Thanks :)

thombet avatar Apr 27 '20 15:04 thombet

Should be a bug, I think.

razzeee avatar Apr 27 '20 18:04 razzeee

iirc it wasn't about using reporter=log at that time. I actually solved this locally/travis by not running kodi-addon-checker from within the add-on structure. ie. C:\addons\>kodi-addon-checker C:\addons\plugin.video.youtube\ --branch leia --reporter=log instead of C:\addons\plugin.video.youtube\>kodi-addon-checker --branch leia --reporter=log The log will be in C:\addons\ in the first example

anxdpanic avatar Apr 27 '20 18:04 anxdpanic

I didn't think about this workaround @anxdpanic, thank you for the idea. I guess it can be used until the bug is fixed.

Thanks for confirming it @Razzeee. I will probably try to submit a pull request to fix the issue at some point but since I don't know the code at all, any suggestion is welcome :)

thombet avatar Apr 27 '20 20:04 thombet

On the other hand, it's probably correct, if you are building a pipeline which automatically creates your addons and will just zip that folder. @enen92

razzeee avatar Apr 28 '20 08:04 razzeee

It turned out to be more complicated than expected especially because:

  • the issue is the same with the debug log so it had to be fixed too
  • I think the correct behavior is to ignore the files having the same name as the logs but not in the current folder

Anyway I submitted the PR #236 and added more info there.

thombet avatar May 02 '20 22:05 thombet