addon-check add check for circular dependencies

add check for circular dependencies

Open anxdpanic opened this issue 6 years ago • 7 comments

For #125

Feb 14 '19 18:02 anxdpanic

Wasn't sure how to approach a test for this at first, working on that now though.

Feb 14 '19 19:02 anxdpanic

Test is added now

Feb 14 '19 20:02 anxdpanic

I have made the required changes ~~, other than the optional/attrib change until further discussion~~

I added some temp logging to show the results against a repo, https://pastebin.com/10Gkw9Jx

Feb 17 '19 20:02 anxdpanic

rebased and resolved merge conflicts and pylint assertions

Mar 17 '19 13:03 anxdpanic

Rebased and resolved the conflicts, is there anything else required for this?

Nov 05 '19 17:11 anxdpanic

Would be great if @Rechi could sign this off too :)

Nov 05 '19 23:11 razzeee

I've removed the local_xml parameter, and moved dependency tree creation to it's own function with it's own test

Nov 06 '19 17:11 anxdpanic