Official-Kodi-Remote-iOS icon indicating copy to clipboard operation
Official-Kodi-Remote-iOS copied to clipboard

Remote tries to connect to Kodi after executing Quit Application

Open kambala-decapitator opened this issue 2 years ago • 5 comments

this should be prevented. Also for Power off, Hibernate and Suspend. In Reboot case I think it can stay.

kambala-decapitator avatar Mar 17 '22 16:03 kambala-decapitator

I understand the motivation behind this, but Imam not quite sure how the behaviour should be.

For example the App could in such case deselect the active server? This would stop searching, but it would be persistent. So, after restart of the App it will not re-connect automatically again and the user needs to explicitly select the server. Not sure if this is desired after a user triggered shutdown, quit or hibernate.

wutschel avatar Mar 18 '22 15:03 wutschel

Yes, basically just disconnect after action execution succeeds.

We can make it configurable via switch in settings with default = false to retain existing behavior.

kambala-decapitator avatar Mar 18 '22 17:03 kambala-decapitator

Ok, I will look into this. But not for 1.10 -- I don't want to add unnecessary risk now.

wutschel avatar Mar 18 '22 17:03 wutschel

that's for sure :)

kambala-decapitator avatar Mar 18 '22 18:03 kambala-decapitator

I did a first proof of concept change which already works basically. But I don't like the overall logic yet.

On server shutdown, quit application: The app will assume the server is down, mark connection "red" and stop pulling. For system reboot I would keep the behaviour as it is -- it will try to reconnect until server is back.

App state:

  • Server still marked as selected, but with "red" connection state
  • Reconnect by user via deselect / select the server (2 tips)
  • After App suspend / wakeup reconnect by user via deselect / select the server (2 tips)
  • After App restart reconnect automatically to the same server

I am not convinced yet by this.

wutschel avatar Feb 27 '23 06:02 wutschel