Kore icon indicating copy to clipboard operation
Kore copied to clipboard

Kore on F-droid version outdated

Open EnerGeh opened this issue 5 years ago • 8 comments

The current proposed version on f-droid is still 2.4.7. I don't know how to fix it, but am very glad to help if you tell me how 😉

EnerGeh avatar Jan 19 '20 21:01 EnerGeh

Supposedly F-Droid should have picked it up automatically - AFAIK as long as we tag the releases F-Droid picks them up. I don't know how they implemented that, but there's already an issue opened on f-droid related to this: https://gitlab.com/fdroid/fdroiddata/issues/1913

The last person that did something on Kore's side regarding f-droid was @mueller-ma so maybe he has some kind of insight into this.

SyncedSynapse avatar Jan 20 '20 18:01 SyncedSynapse

F-Droid didn't try to build the 2.5.0 (versionCode 26): https://f-droid.org/wiki/page/org.xbmc.kore/lastbuild_26 The version code was bumped before tagging the release, so it should be fine. No idea, why F-Droid doesn't build and publish Kore.

mueller-ma avatar Jan 21 '20 08:01 mueller-ma

DEBUG: Directory: build/org.xbmc.kore
DEBUG: > git -c core.askpass=/bin/true -c core.sshCommand=/bin/false -c url.https://.insteadOf=ssh:// -c url.https://u:[email protected]/[email protected]: -c url.https://u:[email protected]=git://bitbucket.org -c url.https://u:[email protected]=https://bitbucket.org -c url.https://u:[email protected]/[email protected]: -c url.https://u:[email protected]=git://github.com -c url.https://u:[email protected]=https://github.com -c url.https://u:[email protected]/[email protected]: -c url.https://u:[email protected]=git://gitlab.com -c url.https://u:[email protected]=https://gitlab.com fetch --prune --tags --force origin
DEBUG: Directory: build/org.xbmc.kore
DEBUG: > git remote set-head origin --auto
DEBUG: Directory: build/org.xbmc.kore
DEBUG: > git checkout -f origin/HEAD
DEBUG: Directory: build/org.xbmc.kore
DEBUG: > git clean -dffx
DEBUG: ...fetch auto name from build/org.xbmc.kore
DEBUG: Parsing manifest at 'build/org.xbmc.kore/build.gradle'
DEBUG: ..got package=None, version=None, vercode=None
DEBUG: Parsing manifest at 'build/org.xbmc.kore/app/src/main/AndroidManifest.xml'
DEBUG: ..got package=org.xbmc.kore, version=None, vercode=None
DEBUG: Parsing manifest at 'build/org.xbmc.kore/app/build.gradle'
DEBUG: ..got package=org.xbmc.kore, version=None, vercode=26
DEBUG: Adding possible subdir app
DEBUG: fetch_real_name: Checking manifest at build/org.xbmc.kore/app/src/main/AndroidManifest.xml
DEBUG: ...got autoname 'Kore'
INFO: Finished

...so no autoupdate because versionName is not static and F-Droid does not parse functions on checkupdate

licaon-kter avatar Jan 21 '20 09:01 licaon-kter

The thing is, it's been like that since ca5023bae789074ff9cf18e53c4c37799888beb4, which was merged 4 years ago, and there have been Kore releases on F-Droid since then. Maybe something changed on F-Droid's mechanism that broke this? I'm not sure, as i don't have any visibility on it.

SyncedSynapse avatar Jan 22 '20 18:01 SyncedSynapse

I saw that, yes, not sure how it worked before.

licaon-kter avatar Jan 22 '20 19:01 licaon-kter

I see that you've already issue a PR on gitlab. I suppose that once that gets merged this gets fixed, right.

SyncedSynapse avatar Jan 22 '20 19:01 SyncedSynapse

Was merged, next cycle should build it. https://f-droid.org/wiki/index.php?title=Special:RecentChanges&days=7&from=&hidebots=0&hideanons=1&hideliu=1&limit=500

licaon-kter avatar Jan 22 '20 19:01 licaon-kter

2.5.1 showed up in f-droid yesterday (https://f-droid.org/packages/org.xbmc.kore/) so I believe this can be closed as fixed?

P.S. Thanks for all the work in developing Kore, it's fantastic!

legoktm avatar Aug 23 '20 11:08 legoktm