Kore Favorites local error with "Unsupported Type"

[vdbpeter]

Bug report

Describe the bug

Here is a clear and concise description of what the problem is:

A Kore error message is generated when a Favourite with type "Unknown" (as displayed in the Kore Favourites tab).

Expected Behavior

Here is a clear and concise description of what was expected to happen:

Browsing the Favourites tab, selecting the Favourite should start the chosen item whether it's an Addon or TV channel etc.

The "ABC News" has "type":"media", and when selected, starts the Addon. The others have "type":"unknown", and errors on the Kore app and wont start.

Actual Behavior

I have “Favourite”d a few Add-ons, but most appear to have an “Unknown” type. When I select one with a type "Unknown", the app errors with message “Unable to play favourite item. Unsupported type”.

Possible Fix

Make it mandatory for Addon developers to include "type".

While the effect is seen in the Kore Remote/Favourites, the cause is probably somewhere deep in the bowels of Kodi. Having chatted with the Foxtel Addon developer (one of the apps that wont start), he is unaware of where the "Type" is set.

To Reproduce

Steps to reproduce the behavior:

1. From within Kodi, select Addons
2. From Addon Categories, select "My Addons"
3. Select an Addon (eg; Youtube)
4. In Context Menu, Select "Add to Favourites"
5. Return to Main Kodi menu
6. Select Favourites from Left menu and confirm presence of Addon.
7. Open Kore app on mobile.
8. Select Favourites from Menu
9. Confirm presence of newly added Favourite.
10. "Unknown" is printed directly under the Favourite label.
11. Selecting this Favourite, generates the error message.

Debuglog

The debuglog can be found here:

When I query Kodi using the jsonrpc, the “unknown” type is coming from Kodi somewhere:

http://10.0.0.109:8080/jsonrpc?request={"jsonrpc":"2.0","method":"Favourites.GetFavourites","id":16,"params":{"properties":["window","windowparameter","thumbnail","path"]}}

{"id":16,"jsonrpc":"2.0","result":{"favourites":[{"path":"pvr://channels/tv/All channels/pvr.hts_389916625.pvr","thumbnail":"http://i.mjh.nz/au/images/tv.101002210220.png","title":"ABC NEWS","type":"media"},{"thumbnail":"/storage/.kodi/addons/plugin.video.netflix/resources/media/icon.png","title":"Netflix","type":"unknown"},{"thumbnail":"/storage/.kodi/addons/plugin.video.foxtel.go/icon.png","title":"Foxtel Go","type":"unknown"},{"thumbnail":"/storage/.kodi/addons/plugin.video.youtube/icon.png","title":"YouTube","type":"unknown"}],"limits":{"end":4,"start":0,"total":4}}}

Screenshots

Here are some links or screenshots to help explain the problem:

Additional context or screenshots (if appropriate)

Here is some additional context or explanation that might help:

IMHO, it's important to fix in order to improve the intuitive nature of the App, making Kodi more enjoyable for the less geeky in my household.

Your Environment

Used Operating system:

• Mobile device: Samsung A5 (2017)
• Android version: 8.0.0
• Kodi version and platform: Kodi 18.2/ LibreELEC 9.02
• Kore version: 2.4.7

note: Once the issue is made we require you to update it with new information or Kodi versions should that be required. Team Kodi will consider your problem report however, we will not make any promises the problem will be solved.