xbvr icon indicating copy to clipboard operation
xbvr copied to clipboard

JAVR Migration from R18 URLs to Japanese FANZA URLs

Open vt-idiot opened this issue 3 years ago • 1 comments

R18 is closing down. Proposing Migration 0042 to fix images.

See #955

I'm not 100% sure I've done this properly, as I just looked at migration 0035 and migration 0036 and tried to copy what they did, but for this scenario.

Ideally you'd select for scenes that have "JAVR" as a tag since the scraper always added that, but that doesn't exist under "scenes" in the database.

I think it doesn't matter in the end since nothing else will be selected against www.r18.com or pics.r18.com?

The only thing I am not sure about is if "CoverURL" and "SceneURL" can be changed in this manner, or if it has to look more like migration 0036.

I left the "SceneURL" change commented out because I'm honestly not sure what to do.

vt-idiot avatar Sep 22 '22 23:09 vt-idiot

gofmt isn't complaining anymore, I think the issue was the block comment not sure if the migration itself would work properly though - reviews welcome...

vt-idiot avatar Sep 23 '22 00:09 vt-idiot

Fixed the conflict with migrations 42 and 43, updated the first comment I opened the PR with a bit to demonstrate what I am trying to do if I've somehow mucked up the migration code.

vt-idiot avatar Oct 05 '22 14:10 vt-idiot

I'd like to merge this PR in the next release. There is still the question regarding the scene URLs. Personally I don't have JAV scenes, so I have no opinion on that. Please decide on your own whether to remove the comment or enable the scene URL migration.

crwxaj avatar Nov 15 '22 12:11 crwxaj

Done. The R18 links already stopped working. The only thing I'm still not certain on is if this Go migration will behave exactly the same way as the SQL I posted above, because I just "monkey see, monkey do"-d another migration into this. ie. will it do this?

  • Scene URL: https://www.r18.com/videos/vod/movies/detail/-/id=kavr00015/ -> https://www.dmm.co.jp/digital/videoa/-/detail/=/cid=kavr00015/
  • Cover URL: https://pics.r18.com/digital/video/kavr00015/kavr00015pl.jpg -> https://pics.dmm.co.jp/digital/video/kavr00015/kavr00015pl.jpg
  • Non-Cover Image URLs: https://pics.r18.com/digital/video/kavr00015/kavr00015jp-1.jpg -> https://pics.dmm.co.jp/digital/video/kavr00015/kavr00015jp-1.jpg

If the code looks like that's what it does, then hooray.

vt-idiot avatar Nov 16 '22 16:11 vt-idiot

The code looks fine to me.

crwxaj avatar Nov 16 '22 16:11 crwxaj