xbvr icon indicating copy to clipboard operation
xbvr copied to clipboard

Column `actions.new_value` length is too short for SLR Originals scenes in MySQL/MariaDB

Open CoolMintChocolate opened this issue 2 years ago • 0 comments

This is an extension of https://github.com/xbapps/xbvr/pull/374

That PR extends the size for new_value to 4095, which is plenty enough for most studios. However, SLR Originals scene file name arrays are now extremely long. For example, out of the box, the scene Your Girlfriend, Kira Perez scenes.filenames_arr column is at 5,387 characters. That is fine for the scenes table because the filenames_arr field is specified as a TEXT field. However, when we match a file with a custom filename to this scene, it will be added to actions.new_value and will fail because that field is specified as varchar(4095). This only affects MySQL/MariaDB because SQLite does not enforce input length.

Tagging @SpedNSFW in this because they're the one creating the PR in the first place. Is it reasonable to simply change the type of new_value to text instead of varchar? As far as I can tell we are not querying on that column so changing the field type shouldn't cause any problem.

CoolMintChocolate avatar Jul 31 '22 00:07 CoolMintChocolate