Xavier Leroy
Xavier Leroy
Thanks for the feedback and testing. Merging!
With this PR, https://github.com/LPCIC/coq-elpi/issues/678 builds fine.
I made this PR against 5.2 to make testing on coq-elpi easier. Should we merge on 5.2 and cherry-pick on trunk, or should I rebase this PR?
Rebased on trunk... done! CI precheck... done! [probably unrelated random failures on tests/lib-runtime-events/test_dropped_events.ml on POWER, to be investigated] This looks ready for merging.
Merged and cherry-picked to 5.2 7af0046399 and to 5.3 85c7730173.
> Should the signal and wait code (basically, threads_posix.h) stay in systhreads? This is an excellent suggestion, even more so given that the implementation of the signal-related Thread function can...
I share @lpw25's skepticism about this PR. It will break a bunch of code in the wild (code of the "buggy but lucky" kind). What do we gain in return?...
> That module was already unsafe to use with multi-threaded programs if you relied on retrieving matched groups (which were stored in a global), but [this PR changed it used...
> Thread programming is pretty much unchanged from OCaml 4. It is not clear to me why you would naturally have more needs of efficient thread-local state in OCaml 5...
> Have you maybe tried indicating dune as an optional dependency? Nice idea! Let's try...