sfDoctrineRestGeneratorPlugin icon indicating copy to clipboard operation
sfDoctrineRestGeneratorPlugin copied to clipboard

Major improvements all over the place!

Open damienalexandre opened this issue 13 years ago • 2 comments

I have some work to contribute on the plugin:

  • Improve the XML and Json serializer (deal with collections, plural naming, Json and XML are now a lot more consistant)
  • Add a camelize option
  • Add a root_name option
  • Add a plural_root_name option
  • Use the query() method in update and delete action (you can now have consistent query on all methods)
  • The validated payload array is now kept and send to updateObjectFromRequest(). This is allowing a lot of flexibility (like saving sfValidatedFile instance i.e.)
  • Updated documentation!

BUT we still need to do some stuff before a 1.0 release imho:

  • recode the post validators logic (to use the full params array on each post validator, same as sfForm)
  • camelize on all the serializer? (only XML do that atm)
  • don't use the templating system (performance)
  • add phpunit test to test the plugin itself (the serializer)

The main issue will be merging my Xml Serializer changes with the ones done in 4ba92e2460aec7288d5800d88d56b8745ad0bdda, unit test can help.

I know symfony standard is lime (and that's why the generated functional test are lime one's) but as plugin developper we can use PhpUnit (which is way more efficient and dev friendly). What do you think about that?

I could work on some test but I'm asking; lime or phpunit?

Have fun merging those stuffs ;-) Cheer.

damienalexandre avatar Oct 26 '11 20:10 damienalexandre

Could you please propose separate atomical pull requests for all these improvements? Thank you :trollface: :wink: :kissing_heart:

xavierlacot avatar Feb 25 '16 00:02 xavierlacot

and do not forget to rebase, you have conflicts. Thanks.

bastnic avatar Feb 25 '16 00:02 bastnic