mobx-keystone icon indicating copy to clipboard operation
mobx-keystone copied to clipboard

update compiler configs and docs

Open sisp opened this issue 2 years ago β€’ 4 comments

It seems using different compiler settings for MobX 4 and 5/6 isn't necessary. Do you think this is generally valid? At least the test suite passes.

sisp avatar Mar 03 '22 15:03 sisp

βœ”οΈ Deploy Preview for mobx-keystone ready!

πŸ”¨ Explore the source changes: d5faaba95f5d7268ffb5b568eba9a12c530d30f6

πŸ” Inspect the deploy log: https://app.netlify.com/sites/mobx-keystone/deploys/6220da16abd31100077013b7

😎 Browse the preview: https://deploy-preview-421--mobx-keystone.netlify.app

netlify[bot] avatar Mar 03 '22 15:03 netlify[bot]

Codecov Report

Merging #421 (d5faaba) into master (17ffa8e) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #421   +/-   ##
=======================================
  Coverage   90.93%   90.93%           
=======================================
  Files         179      179           
  Lines        6388     6388           
  Branches     1168     1157   -11     
=======================================
  Hits         5809     5809           
  Misses        542      542           
  Partials       37       37           

Continue to review full report at Codecov.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 17ffa8e...d5faaba. Read the comment docs.

codecov[bot] avatar Mar 03 '22 15:03 codecov[bot]

I don't know, I think those config were taken directly from mobx docs, so while they might work with keystone they might not work if you use decorators for mobx itself

xaviergonz avatar Mar 05 '22 11:03 xaviergonz

Okay, I'll investigate a bit further.

sisp avatar Mar 06 '22 10:03 sisp